Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow overiding currentDate in the evaluation context #2127

Merged
merged 9 commits into from
Jul 24, 2024

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Jul 22, 2024

Description

In this PR, we allow to override the current date by a specific field in the evaluation context.
By setting it, we will use this date instead of time.Now().

Closes issue(s)

Resolve #2054

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit d127a8d
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/66a0ab43bf143a00089300d9

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (32f4a51) to head (d127a8d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2127      +/-   ##
==========================================
+ Coverage   86.34%   86.40%   +0.06%     
==========================================
  Files          98       98              
  Lines        3661     3678      +17     
==========================================
+ Hits         3161     3178      +17     
  Misses        382      382              
  Partials      118      118              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Copy link

@thomaspoignant thomaspoignant merged commit 432fcac into main Jul 24, 2024
21 checks passed
@thomaspoignant thomaspoignant deleted the feat-2054 branch July 24, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) Specify custom field key for evaluation date time of scheduled rollout
1 participant