[charts] Fix the font used in the overlay (mui#13107)

thomasmoon · Sep 6, 2024 · 9dd6c08 · 9dd6c08
1 parent 483c656
commit 9dd6c08
Show file tree

Hide file tree

Showing 11 changed files with 20 additions and 6 deletions.
diff --git a/docs/pages/x/api/charts/bar-chart.json b/docs/pages/x/api/charts/bar-chart.json
@@ -37,7 +37,7 @@
       "type": { "name": "union", "description": "object<br>&#124;&nbsp;string" },
       "default": "yAxisIds[0] The id of the first provided axis"
     },
-    "loading": { "type": { "name": "bool" } },
+    "loading": { "type": { "name": "bool" }, "default": "false" },
     "margin": {
       "type": {
         "name": "shape",

diff --git a/docs/pages/x/api/charts/line-chart.json b/docs/pages/x/api/charts/line-chart.json
@@ -34,7 +34,7 @@
       "type": { "name": "union", "description": "object<br>&#124;&nbsp;string" },
       "default": "yAxisIds[0] The id of the first provided axis"
     },
-    "loading": { "type": { "name": "bool" } },
+    "loading": { "type": { "name": "bool" }, "default": "false" },
     "margin": {
       "type": {
         "name": "shape",

diff --git a/docs/pages/x/api/charts/pie-chart.json b/docs/pages/x/api/charts/pie-chart.json
@@ -39,7 +39,7 @@
       "deprecated": true,
       "deprecationInfo": "Consider using <code>slotProps.legend</code> instead."
     },
-    "loading": { "type": { "name": "bool" } },
+    "loading": { "type": { "name": "bool" }, "default": "false" },
     "margin": {
       "type": {
         "name": "shape",

diff --git a/docs/pages/x/api/charts/scatter-chart.json b/docs/pages/x/api/charts/scatter-chart.json
@@ -34,7 +34,7 @@
       "type": { "name": "union", "description": "object<br>&#124;&nbsp;string" },
       "default": "yAxisIds[0] The id of the first provided axis"
     },
-    "loading": { "type": { "name": "bool" } },
+    "loading": { "type": { "name": "bool" }, "default": "false" },
     "margin": {
       "type": {
         "name": "shape",

diff --git a/packages/x-charts/src/BarChart/BarChart.tsx b/packages/x-charts/src/BarChart/BarChart.tsx
@@ -298,6 +298,7 @@ BarChart.propTypes = {
   }),
   /**
    * If `true`, a loading overlay is displayed.
+   * @default false
    */
   loading: PropTypes.bool,
   /**

diff --git a/packages/x-charts/src/ChartsOverlay/ChartsLoadingOverlay.tsx b/packages/x-charts/src/ChartsOverlay/ChartsLoadingOverlay.tsx
@@ -4,6 +4,7 @@ import { useDrawingArea } from '../hooks/useDrawingArea';
 import type { CommonOverlayProps } from './ChartsOverlay';
 
 const StyledText = styled('text')(({ theme }) => ({
+  ...theme.typography.body2,
   stroke: 'none',
   fill: theme.palette.text.primary,
   shapeRendering: 'crispEdges',
@@ -17,7 +18,7 @@ export function ChartsLoadingOverlay(props: CommonOverlayProps) {
 
   return (
     <StyledText x={left + width / 2} y={top + height / 2} {...other}>
-      {message ?? 'Loading data ...'}
+      {message ?? 'Loading data…'}
     </StyledText>
   );
 }
diff --git a/packages/x-charts/src/ChartsOverlay/ChartsNoDataOverlay.tsx b/packages/x-charts/src/ChartsOverlay/ChartsNoDataOverlay.tsx
@@ -4,6 +4,7 @@ import { useDrawingArea } from '../hooks/useDrawingArea';
 import type { CommonOverlayProps } from './ChartsOverlay';
 
 const StyledText = styled('text')(({ theme }) => ({
+  ...theme.typography.body2,
   stroke: 'none',
   fill: theme.palette.text.primary,
   shapeRendering: 'crispEdges',

diff --git a/packages/x-charts/src/ChartsOverlay/ChartsOverlay.tsx b/packages/x-charts/src/ChartsOverlay/ChartsOverlay.tsx
@@ -46,10 +46,18 @@ export interface ChartsOverlaySlotProps {
 export interface ChartsOverlayProps {
   /**
    * If `true`, a loading overlay is displayed.
+   * @default false
    */
   loading?: boolean;
-
+  /**
+   * Overridable component slots.
+   * @default {}
+   */
   slots?: ChartsOverlaySlots;
+  /**
+   * The props used for each component slot.
+   * @default {}
+   */
   slotProps?: ChartsOverlaySlotProps;
 }
 

diff --git a/packages/x-charts/src/LineChart/LineChart.tsx b/packages/x-charts/src/LineChart/LineChart.tsx
@@ -320,6 +320,7 @@ LineChart.propTypes = {
   }),
   /**
    * If `true`, a loading overlay is displayed.
+   * @default false
    */
   loading: PropTypes.bool,
   /**

diff --git a/packages/x-charts/src/PieChart/PieChart.tsx b/packages/x-charts/src/PieChart/PieChart.tsx
@@ -266,6 +266,7 @@ PieChart.propTypes = {
   }),
   /**
    * If `true`, a loading overlay is displayed.
+   * @default false
    */
   loading: PropTypes.bool,
   /**

diff --git a/packages/x-charts/src/ScatterChart/ScatterChart.tsx b/packages/x-charts/src/ScatterChart/ScatterChart.tsx
@@ -266,6 +266,7 @@ ScatterChart.propTypes = {
   }),
   /**
    * If `true`, a loading overlay is displayed.
+   * @default false
    */
   loading: PropTypes.bool,
   /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -298,6 +298,7 @@ BarChart.propTypes = { @@
       }),
       /**
        * If `true`, a loading overlay is displayed.
+       * @default false
        */
       loading: PropTypes.bool,
       /**
@@ Expand Down @@