Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Simon's problem on slack:
julia> F, a = cyclotomic_field(7,:a)
(Cyclotomic field of order 7, a)
julia> P,x = polynomial_ring(F,:x)
(Univariate polynomial ring in x over F, x)
julia> FG,dd = number_field(x^6 + (133486969//288a^5 - 223759151//432a^4 - 223759151//432a^3 + 133486969//288a^2 - 232474865//288)x^3 - 840539241479//13824a^5 - 18036715089631//9216a^4 - 18036715089631//9216a^3 - 840539241479//13824*a^2 - 7320065966297//9216) (Relative number field of degree 6 over F, _$)
julia> is_abelian(FG)
ERROR: Number field element not in the order
Stacktrace:
...
The same problem (plus some more) also would have prevented maximal_abelian_subfield(FG, of_closure = true)
to have been correct
The runtime of those examples is a bit high for testing (always)