Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring algebras into shape #1588

Merged
merged 1 commit into from
Sep 7, 2024

feat: bring algebras into shape

ee36582
Select commit
Loading
Failed to load commit list.
Merged

feat: bring algebras into shape #1588

feat: bring algebras into shape
ee36582
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 7, 2024 in 0s

75.70% (+70.26%) compared to ee980a7

View this Pull Request on Codecov

75.70% (+70.26%) compared to ee980a7

Details

Codecov Report

Attention: Patch coverage is 91.23649% with 73 lines in your changes missing coverage. Please review.

Project coverage is 75.70%. Comparing base (ee980a7) to head (ee36582).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/AlgAss/Conversions.jl 82.03% 67 Missing ⚠️
src/AlgAss/AbsAlgAss.jl 72.72% 3 Missing ⚠️
src/AlgAss/Decompose.jl 99.33% 2 Missing ⚠️
src/AlgAss/StructureConstantAlgebra.jl 99.20% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1588       +/-   ##
===========================================
+ Coverage    5.44%   75.70%   +70.26%     
===========================================
  Files         358      362        +4     
  Lines      113490   113899      +409     
===========================================
+ Hits         6183    86231    +80048     
+ Misses     107307    27668    -79639     
Files with missing lines Coverage Δ
src/AlgAss/AlgGrp.jl 72.89% <100.00%> (+72.89%) ⬆️
src/AlgAss/AlgMat.jl 88.54% <100.00%> (+88.54%) ⬆️
src/AlgAss/Elem.jl 88.68% <100.00%> (+88.68%) ⬆️
src/AlgAssAbsOrd/Elem.jl 84.51% <100.00%> (+84.51%) ⬆️
src/AlgAssAbsOrd/Ideal.jl 77.04% <100.00%> (+77.04%) ⬆️
src/AlgAss/StructureConstantAlgebra.jl 93.44% <99.20%> (ø)
src/AlgAss/Decompose.jl 99.33% <99.33%> (ø)
src/AlgAss/AbsAlgAss.jl 88.05% <72.72%> (+88.05%) ⬆️
src/AlgAss/Conversions.jl 82.03% <82.03%> (ø)

... and 317 files with indirect coverage changes