Modular Wallet Types #834
Open
Modular Wallet Types #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // type WalletType = | ||
| // | (typeof ACCOUNT_PLUGINS)[number]["type"] | ||
| // | `smart:${(typeof ACCOUNT_PLUGINS)[number]["type"]}`; |
| const awsKmsArn = res.KeyMetadata.Arn; | ||
| const { keyId } = splitAwsKmsArn(awsKmsArn); | ||
|
|
||
| const account = await getAwsKmsAccount({ |
There was a problem hiding this comment.
one day you should extract this into the sdk :D
| type AwsKmsCredential = z.infer<typeof awsKmsCredentialSchema>; | ||
|
|
||
| // AWS KMS Plugin Definition | ||
| export const awsKmsPlugin = defineAccountPlugin({ |
There was a problem hiding this comment.
i was expecting to see a plugin for GCP and one for private key as well? is it just not implemented yet?
There was a problem hiding this comment.
yep, need to extract the exiting code into this plugin format. Will also be adding one for circle
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on migrating the project from
yarntopnpmfor package management, alongside various code refactors and improvements in wallet handling and configuration management.Detailed summary
yarnconfiguration files andyarn.lock.pnpminstead ofyarn.decryptfunctions to enhance password handling.walletProviderCredentialsSchemafor better credential management.CircleCredentialschema for Circle wallet integration.