Fix sqlite database is locked #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a record already exists in the db messages table, then it first executes the delete sql but does not commit yet, then starts another SQLiteEventStorage instance at tb_gateway_remote_configurator.py:346, i.e., another sqlite database connection, and again executes the the same delete sql, so the result is a locked database exception.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a record already exists in the db messages table, then it first executes the delete sql but does not commit yet, then starts another SQLiteEventStorage instance at #tb_gateway_remote_configurator.py:346 i.e., another sqlite database connection, and again executes the the same delete sql, so the result is a locked database exception.
This exception can be avoided by adding either
self.db.commit()orself._gateway._event_storage.stop().I think this could also solve this issue: #1446 (comment)