-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lywsd03mmc sensor #636
Conversation
Dude, that is way cool! I am unable to test this all, so I am very happy that you are trying to add this. I made 2 remarks on your PR. Could you have a look at them? |
I have some changes I'll be pushing in a few moments, but I don't see your comments on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this show up the two remarks?
Also, the Makefile change isn't strictly required, I just found it useful while I was testing. I can break it out into another PR if you'd like to polish that elsewhere first. |
It turns out that the bluetooth scanning in TerrariumPI is really pretty nice, I apparently never really had it working in my setup. This is pretty well finalized, can you review this again? |
And if you could also update the composer example in: https://github.com/theyosh/TerrariumPI/blob/main/docs/_tabs/install.md?plain=1#L79 And if the device looks the same as the 'original' MiTemp, then you could just copy https://github.com/theyosh/TerrariumPI/blob/main/docs/_hardware/mitemp_sensor.md?plain=1 to Then the documentation is also up to date. |
Hi, do you have time to update the documentation? If not, I can do it also.... not a problem. Then I can merge this PR |
Yes, I'll be working on docs today. |
This device actually has a smiley face so I don't know if you want to update the photo as well. |
Thanks a lot! And merry Christmas |
TODO:
Merging this will close #635