Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime suspend/resume doesn't work when no hdmi pipelines defined in tplg file(with idisp BEs defined in machine driver). #234

Closed
keyonjie opened this issue Oct 31, 2018 · 7 comments
Closed

runtime suspend/resume doesn't work when no hdmi pipelines defined in tplg file(with idisp BEs defined in machine driver). #234

keyonjie opened this issue Oct 31, 2018 · 7 comments
Assignees
@stripes416
Labels
enhancement New feature or request

Comments

@keyonjie
Copy link

it can't enter suspend as hdmi codec driver is always waiting for hdmi codec probing.
@keyonjie keyonjie added the enhancement New feature or request label Oct 31, 2018
@plbossart
Copy link
Member

@keyonjie thanks for report. Can you please add more details so that people can reproduce your finding?

@mengdonglin mengdonglin mentioned this issue Nov 9, 2018
Closed
@plbossart
Copy link
Member

@keyonjie this issue has not been updated since October 31, 2018, there is no description of the issue. Should it be closed or is this still open?

@stripes416 stripes416 self-assigned this Mar 26, 2019
@stripes416
Copy link

@keyonjie I've tested this on my up2 board to see if this is still an issue (per @ranj063 recommendations) I'm not seeing the issue you mentioned, but full disclosure, I couldn't replicate the issue as described either.

I tested sof-apl-pcm512x.tplg from latest topic/sof-dev built with and without HDA.

I've included two files - each containing data from one of the runs:
dmesg logs + the output from 'cat /proc/asound/pcm' + the output of alias
pcm_status="cat /sys/bus/pci/devices/0000\:00\:0e.0/power/runtime_status"

pcm_dmesg_with-HDA.txt
pcm_dmesg_no-HDA.txt

@keyonjie
Copy link
Author

@stripes416 @zhuyingjiang the issue happened at when there is no hdmi/idisp pcm defined in tplg file, it was firstly found by @bardliao iirc, Bard and Libin did some work on that, I am not sure if it is already fixed in the latest code base, Can you comment out these in sof-apl-pcm512.m4 and retry if you can enter suspend?

# Low Latency playback pipeline 2 on PCM 1 using max 2 channels of s32le.
# Schedule 48 frames per 1000us deadline on core 0 with priority 0
PIPELINE_PCM_ADD(sof/pipe-volume-playback.m4,
        2, 1, 2, s32le,
        48, 1000, 0, 0)

# Low Latency playback pipeline 3 on PCM 2 using max 2 channels of s32le.
# Schedule 48 frames per 1000us deadline on core 0 with priority 0
PIPELINE_PCM_ADD(sof/pipe-volume-playback.m4,
        3, 2, 2, s32le,
        48, 1000, 0, 0)

# Low Latency playback pipeline 4 on PCM 3 using max 2 channels of s32le.
# Schedule 48 frames per 1000us deadline on core 0 with priority 0
PIPELINE_PCM_ADD(sof/pipe-volume-playback.m4,
        4, 3, 2, s32le,
        48, 1000, 0, 0)

@zhuyingjiang
Copy link

I verified on Up2 with sof-apl-pcm512x-nohdmi.tplg, the Up2 can normally do suspend/resume. So we can close this issue.

@keyonjie
Copy link
Author

good, thanks @zhuyingjiang and @stripes416

@stripes416
Copy link

@zhuyingjiang & @keyonjie Thanks!

aiChaoSONG pushed a commit to aiChaoSONG/linux that referenced this issue May 6, 2021
@ojeda
Merge pull request thesofproject#234 from Kloenk/improved_macro
c3410c1 
make module! arguments optional
bardliao pushed a commit to bardliao/linux that referenced this issue Dec 20, 2024
@namjaejeon
ksmbd: set ATTR_CTIME flags when setting mtime
21e46a7 
David reported that the new warning from setattr_copy_mgtime is coming
like the following.

[  113.215316] ------------[ cut here ]------------
[  113.215974] WARNING: CPU: 1 PID: 31 at fs/attr.c:300 setattr_copy+0x1ee/0x200
[  113.219192] CPU: 1 UID: 0 PID: 31 Comm: kworker/1:1 Not tainted 6.13.0-rc1+ thesofproject#234
[  113.220127] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.2-3-gd478f380-rebuilt.opensuse.org 04/01/2014
[  113.221530] Workqueue: ksmbd-io handle_ksmbd_work [ksmbd]
[  113.222220] RIP: 0010:setattr_copy+0x1ee/0x200
[  113.222833] Code: 24 28 49 8b 44 24 30 48 89 53 58 89 43 6c 5b 41 5c 41 5d 41 5e 41 5f 5d c3 cc cc cc cc 48 89 df e8 77 d6 ff ff e9 cd fe ff ff <0f> 0b e9 be fe ff ff 66 0
[  113.225110] RSP: 0018:ffffaf218010fb68 EFLAGS: 00010202
[  113.225765] RAX: 0000000000000120 RBX: ffffa446815f8568 RCX: 0000000000000003
[  113.226667] RDX: ffffaf218010fd38 RSI: ffffa446815f8568 RDI: ffffffff94eb03a0
[  113.227531] RBP: ffffaf218010fb90 R08: 0000001a251e217d R09: 00000000675259fa
[  113.228426] R10: 0000000002ba8a6d R11: ffffa4468196c7a8 R12: ffffaf218010fd38
[  113.229304] R13: 0000000000000120 R14: ffffffff94eb03a0 R15: 0000000000000000
[  113.230210] FS:  0000000000000000(0000) GS:ffffa44739d00000(0000) knlGS:0000000000000000
[  113.231215] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  113.232055] CR2: 00007efe0053d27e CR3: 000000000331a000 CR4: 00000000000006b0
[  113.232926] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[  113.233812] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[  113.234797] Call Trace:
[  113.235116]  <TASK>
[  113.235393]  ? __warn+0x73/0xd0
[  113.235802]  ? setattr_copy+0x1ee/0x200
[  113.236299]  ? report_bug+0xf3/0x1e0
[  113.236757]  ? handle_bug+0x4d/0x90
[  113.237202]  ? exc_invalid_op+0x13/0x60
[  113.237689]  ? asm_exc_invalid_op+0x16/0x20
[  113.238185]  ? setattr_copy+0x1ee/0x200
[  113.238692]  btrfs_setattr+0x80/0x820 [btrfs]
[  113.239285]  ? get_stack_info_noinstr+0x12/0xf0
[  113.239857]  ? __module_address+0x22/0xa0
[  113.240368]  ? handle_ksmbd_work+0x6e/0x460 [ksmbd]
[  113.240993]  ? __module_text_address+0x9/0x50
[  113.241545]  ? __module_address+0x22/0xa0
[  113.242033]  ? unwind_next_frame+0x10e/0x920
[  113.242600]  ? __pfx_stack_trace_consume_entry+0x10/0x10
[  113.243268]  notify_change+0x2c2/0x4e0
[  113.243746]  ? stack_depot_save_flags+0x27/0x730
[  113.244339]  ? set_file_basic_info+0x130/0x2b0 [ksmbd]
[  113.244993]  set_file_basic_info+0x130/0x2b0 [ksmbd]
[  113.245613]  ? process_scheduled_works+0xbe/0x310
[  113.246181]  ? worker_thread+0x100/0x240
[  113.246696]  ? kthread+0xc8/0x100
[  113.247126]  ? ret_from_fork+0x2b/0x40
[  113.247606]  ? ret_from_fork_asm+0x1a/0x30
[  113.248132]  smb2_set_info+0x63f/0xa70 [ksmbd]

ksmbd is trying to set the atime and mtime via notify_change without also
setting the ctime. so This patch add ATTR_CTIME flags when setting mtime
to avoid a warning.

Reported-by: David Disseldorp <[email protected]>
Signed-off-by: Namjae Jeon <[email protected]>
Signed-off-by: Steve French <[email protected]>
bardliao pushed a commit to bardliao/linux that referenced this issue Jan 14, 2025
@covanam @palmer-dabbelt
riscv: Fix sleeping in invalid context in die()
6a97f41 
die() can be called in exception handler, and therefore cannot sleep.
However, die() takes spinlock_t which can sleep with PREEMPT_RT enabled.
That causes the following warning:

BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 285, name: mutex
preempt_count: 110001, expected: 0
RCU nest depth: 0, expected: 0
CPU: 0 UID: 0 PID: 285 Comm: mutex Not tainted 6.12.0-rc7-00022-ge19049cf7d56-dirty thesofproject#234
Hardware name: riscv-virtio,qemu (DT)
Call Trace:
    dump_backtrace+0x1c/0x24
    show_stack+0x2c/0x38
    dump_stack_lvl+0x5a/0x72
    dump_stack+0x14/0x1c
    __might_resched+0x130/0x13a
    rt_spin_lock+0x2a/0x5c
    die+0x24/0x112
    do_trap_insn_illegal+0xa0/0xea
    _new_vmalloc_restore_context_a0+0xcc/0xd8
Oops - illegal instruction [#1]

Switch to use raw_spinlock_t, which does not sleep even with PREEMPT_RT
enabled.

Fixes: 76d2a04 ("RISC-V: Init and Halt Code")
Signed-off-by: Nam Cao <[email protected]>
Cc: [email protected]
Reviewed-by: Sebastian Andrzej Siewior <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Palmer Dabbelt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stripes416 stripes416

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@plbossart @keyonjie @stripes416 @zhuyingjiang