Fix unicode/str inconsistency in Python 2 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This encodes environment keys and values for `os.environ` in Python 2 and fixes the following issues: * Values loaded from `.env` being `unicode` whereas regular values being `str` (i.e. `bytes`) in Python 2. * Error when loading `.env` with UTF-8 characters in Python 2. * `# type: ignore` hiding the issue from the type checker. `sys.getfilesystemencoding()` is used because it seems to match the encoding used for environment variables with Python 2. Since it can apparently return `None`, we fall back to a default encoding (UTF-8 here) if that's the case. I tested this on Windows where `"mbcs"` is the file system encoding. Hopefully, this will also work on other systems.
4 similar comments
theskumar
approved these changes
May 12, 2019
|
thanks this looks great! |
theskumar
pushed a commit
that referenced
this pull request
Jun 2, 2019
* master: (49 commits) Fix typo in README.md (#181) Refactor move run_command in cli Refractor: move 'to_env' to compat.py Refactor parser to fix inconsistencies (#180) chore(pypi): switch to markdown and twine for pypi upload + update supported version Bump version: 0.10.1 → 0.10.2 readme: Add new release stub Fix unicode/str inconsistency in Python 2 (#177) Add argument to choose .env file encoding, defaults to None Fix links in readme Restrict typing dependency to Python < 3.5 Add type hints and expose them to users Updated `.gitignore` with results from https://www.gitignore.io/api/python Added special case for `__file__` in Python 2. Fixes #130 Updated tests to show that this works. Moved `dotenv` package into `src` directory so that tests run against installed version. Added tox to run test suite against multiple versions of Python (with coverage) and run flake8. Updated Travis CI to use tox as well. Updated documentation about running tests. Fix ResourceWarning: unclosed file in setup.py and test_cli.py Clarify the usuages of export Isolate test files (#160) Deleted some temporary files that CLI tests were creating. Add python 3.7 to testsuite + udpate pypi creds ...
johnbergvall
pushed a commit
to johnbergvall/python-dotenv
that referenced
this pull request
Aug 13, 2021
This encodes environment keys and values for `os.environ` in Python 2 and fixes the following issues: * Values loaded from `.env` being `unicode` whereas regular values being `str` (i.e. `bytes`) in Python 2. * Error when loading `.env` with UTF-8 characters in Python 2. * `# type: ignore` hiding the issue from the type checker. `sys.getfilesystemencoding()` is used because it seems to match the encoding used for environment variables with Python 2. Since it can apparently return `None`, we fall back to a default encoding (UTF-8 here) if that's the case. I tested this on Windows where `"mbcs"` is the file system encoding. Hopefully, this will also work on other systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encodes environment keys and values for
os.environin Python 2and fixes the following issues:
.envbeingunicodewhereas regular values beingstr(i.e.bytes) in Python 2..envwith UTF-8 characters in Python 2.# type: ignorehiding the issue from the type checker.sys.getfilesystemencoding()is used because it seems to match theencoding used for environment variables with Python 2. Since it can
apparently return
None, we fall back to a default encoding (UTF-8here) if that's the case.
I tested this on Windows where
"mbcs"is the file system encoding.Hopefully, this will also work on other systems.
Closes #121. Closes #176.