Fix inconsistent persistDeviceCode
usage
#1446
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On "Device Authorization" grant, the
\League\OAuth2\Server\Repositories\DeviceCodeRepositoryInterface::persistDeviceCode()
method has been used 3 times with 3 different purposes:This makes the implementation of this method too hard, as we have to manually determine that for which purpose this method has been called!
You may check the workaround I had to use to be able to implement this on Laravel Passport here.
This PR adds 2 new methods to fix this:
\League\OAuth2\Server\Repositories\DeviceCodeRepositoryInterface::persistUser()
\League\OAuth2\Server\Repositories\DeviceCodeRepositoryInterface::persistLastPolledAt()