Fix "state" parameter of error responses #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please can you provide some information about why you want to add this change? Thank you |
|
I added description I hope it is clear enough. |
|
Just merged |
hafezdivandari
changed the title
|
Thanks for this @hafezdivandari - the code looks good. I was wondering if you would be up for adding some tests to ensure we don't add any regressions for this in future. Because I've taken so long to get around to this, if you don't have time I will try to add them in myself and we can then get this merged. If it is also possible to add a changelog entry that would be appreciated but I can do this myself if you don't have time. Thanks so much for this! |
|
@Sephster just added some tests and a changelog entry. |
|
Thanks for this @hafezdivandari - looks great |
ajgarlag
added a commit
to ajgarlag/oauth2-server-bundle
that referenced
this pull request
Oct 15, 2024
chalasr
added a commit
to thephpleague/oauth2-server-bundle
that referenced
this pull request
Oct 16, 2024
This PR was squashed before being merged into the 0.9-dev branch. Discussion ---------- Fix Ci - Fix CS - Fix failing tests related to thephpleague/oauth2-server#1298 Commits ------- 9dfd8cc Fix tests 568c7de Fix CS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 6749 on error response of the implicit grant, the authorization server should add parameters to the fragment component of the redirection URI and the
stateparameter is required if it was present on the request.There already 2 error responses that have redirect URI:
Invalid_scope:stateparameter when redirecting. This PR fixes this on both 'auth code' and 'implicit' grants.http://example.com/callback?error=access_denied&error_description=...http://example.com/callback?state=123&error=access_denied&error_description=...http://example.com/callback#error=access_denied&error_description=...http://example.com/callback#state=123&error=access_denied&error_description=...access_denied: This error response does include thestateparameter when redirecting as expected, but when using implicit grant, the error'sstateparameter is on query string and other parameters were on fragment component. This PR fixes this.http://example.com/callback?state=123#error=access_denied&error_description=...http://example.com/callback#state=123&error=access_denied&error_description=...