Add switch to prevent revoking of refresh tokens. #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @janhopman-nhb - is there a way to implement this that won't break BC? If not, I think we will leave this PR for now. I also want to change refresh tokens so they don't have an expiration as this isn't part of the spec so would like to roll that into one as part of a major release. Thanks |
|
Hi @Sephster, Thank you for your reply! We will have a look if we can implement without breaking BC. |
|
Hi @Sephster, is it possible to approve running the workflows by any chance? |
|
Done, thanks! |
|
@Sephster Really sorry for bothering you... 😅 Just fixed the bc issue i think, but the workflows need to be triggerd again to confirm... |
Sephster
requested changes
May 31, 2021
added 2 commits
June 1, 2021 09:24
…ge, cleaned up constructor.
Sephster
approved these changes
Jun 3, 2021
|
LGTM - thank you for your work on this @janhopman-nhb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Recently we (my colleagues and i) came across a specific use case in our software which uses oauth2-server where we needed to prevent refresh tokens to be revoked after requesting a new access token. We looked at the ouath rfc and read that this behaviour is allowed according to the spec. I've gone ahead and implemented the change in this pull request. See below for references to the specific information on refresh tokens in the rfc.
According to section 1.5, issuing a new refresh token is optional (see step H).
Also according to section 4.1 which describes the authorization code grant type, the refresh token is optional (see step E).
Finally according to section 6 (Refreshing an Access token), in the last paragraph it states that the server MAY issue a new refresh token.
And also states that the server MAY revoke the old refresh token.
Hoping someone can take a look at this, any suggestions and/or feedback, would be much appreciated!