Add previous authorized token information to getNewToken() #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a problem because it makes it impossible to later do a access_token request without a redirect_uri.
This is important because at AuthCodeGrant line 211 the redirect_uri of the code payload is checked. Since that payload can never be empty it makes it impossible to request a access_token without a redirect_uri.
…toryInterface::getNewToken() to help issue AccessToken with the correct permissions
Richard87
force-pushed
the
authcode-ref2
branch
from
5fb5541 to
b535527
Compare
|
I forced push my commit without a merge-commit I found, removed a bunch of unrelated commits to the PR, but there are still 4 commits in the PR I don't understand comes from! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1103 and #672 and possibly #885
Ping: @Sephster
Does this look good? I'm pretty new to creating pull-requests!
(I used PHPStorms "Rebase onto branch... 9.0.0-WIP", and renamed my branch... Hope that solves the issue!)