Skip to content
This repository has been archived by the owner on Apr 4, 2020. It is now read-only.

readme: document extensions #15

Merged
merged 1 commit into from
Mar 10, 2019
Merged

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Mar 10, 2019

Copy link
Member

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@colinodell colinodell merged commit 8f4692c into thephpleague:master Mar 10, 2019
@glensc glensc deleted the patch-1 branch March 11, 2019 08:48
@glensc
Copy link
Contributor Author

glensc commented Mar 11, 2019

@colinodell uh, looks like there's duplicate extension

https://github.com/thephpleague/commonmark/tree/94305093262b9448b1aa8d40eb1178c2ad0508a5#league-extensions:

league/commonmark-ext-smartpunct ( 2 hours ago) - Intelligently converts ASCII quotes, dashes, and ellipses to their Unicode equivalents

@colinodell
Copy link
Member

Yep I just created that today. My goal is to pull out the individual extensions and then deprecate this one.

@glensc
Copy link
Contributor Author

glensc commented Mar 12, 2019

what about strikethrough then? #18

I attempted to finish the previous PR.

@colinodell
Copy link
Member

We can merge that once completed, pull that into a separate repo, and then decide what do with this one.

Right now I'm thinking we'll either deprecate / "abandon" this package or turn it into a meta-package which pulls in the things we've split off. I'm currently leaning towards that second option.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants