Updates to #1231 - multiple event listeners #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…video.js into review-themicp-feature/multiple-event-register
|
Overall it seems good, I noted only one thing in the tests for |
|
Cool, got that fixed now. If you can pull this in I'll pull it into the main project. |
themicp
added a commit
that referenced
this pull request
Jul 2, 2014
…-register Updates to videojs#1231 - multiple event listeners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few updates to your pull request. Can you check them out to see if you're ok with them and accept this pull request if you are?
The last two commits are the relevant ones.