Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdowns - format tweaks #276

Closed
jjagielka opened this issue Sep 8, 2022 · 4 comments
Closed

Dropdowns - format tweaks #276

jjagielka opened this issue Sep 8, 2022 · 4 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation v1.6.3 Issues and tasks for v1.6.3 release

Comments

@jjagielka
Copy link

Describe the bug
Dropdown is like a List group merged with Tooltip (or rather Popover). However it does not look consistent with those:

  • rounding: Dropdown uses class rounded while List group, Tooltip, Popover and even Card, Button, Toast and Modal all use rounded-lg
  • space filling: List group fills the parent space fully i.e. first and last item are rounded in accordance with parent rounding. Dropdown however uses py-1 on the parent, preventing items to fill the space fully (look at the hovering).

To Reproduce
Steps to reproduce the behavior:

  1. Go to Dropdown and play with the hover
  2. Go to List Group with icons and play with the hover
  3. Observe the differences

Expected behavior
Dropdown to look more like List group

Screenshots

image

Additional context
Add any other context about the problem here.

@zoltanszogyenyi
Copy link
Member

Hey @jjagielka,

Thanks for the feedback.

This is something I'll have to pass by the design team.

@robert1508 what do you think?

@robert1508
Copy link
Member

Hello there,

When there are no lines between the nav items, additional space must be placed to have visual consistency between the nav items and the dropdown menu itself. But of course, we will also add a variant similar to List group.

@jjagielka
Copy link
Author

Even button is rounded-lg and looks strange with rounded only dropdown.

image

@zoltanszogyenyi
Copy link
Member

Hello @jjagielka,

I have updated all of the dropdown components (29c4ca3) to now use rounded-lg and also added py-2 instead of py-1 to the spacing between the menu items to better match the distance between items. Later we will make these updates to the block collection and templates.

This will be launched and deployed on the docs when v1.6.3 will be published.

Cheers,
Zoltan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation v1.6.3 Issues and tasks for v1.6.3 release
Projects
None yet
Development

No branches or pull requests

3 participants