Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Channel list" to network context menu #1802

Merged
merged 1 commit into from
Dec 9, 2017
Merged

Add "Channel list" to network context menu #1802

merged 1 commit into from
Dec 9, 2017

Conversation

MaxLeiter
Copy link
Member

@MaxLeiter MaxLeiter commented Dec 6, 2017

No clue if we want this or not, I'm a fan. 🤷‍♂️

I just think some commands should be more accessible from the UI

image

@astorije
Copy link
Member

astorije commented Dec 6, 2017

I just think some commands should be more accessible from the UI

💯

text: "Channel list",
data: target.data("target"),
});
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this under the divider?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

if (target.hasClass("lobby")) {
output += templates.contextmenu_item({
class: "list",
text: "Channel list",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debating if it would not be more user-friendly to have something like "List channels on this server" or something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that’s too long... maybe “List existing channels”?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it's too long.

Maybe "List Channels" or "List all channels" or "List of Channels" or something.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see whats wrong with Channel List, its pretty straight forward. List Channels would fit better to disconnect tho since both are an action.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the issue with "Channel List" or "List Channels" is ... what channels? But none of our solutions fix that problem, really. I'd be fine with any of these other than "List channels on this server"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2017-12-06 at 18 36 45

🤷‍♂️

Let's go with "List all channels" then.

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Dec 6, 2017
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor label change, but aside that, it works and it's a great thing to have. Thanks!!

(Not for this PR) It would also be nice to add an entry in channel dropdowns to add "List all banned users" that would call /banlist :)

if (target.hasClass("lobby")) {
output += templates.contextmenu_item({
class: "list",
text: "Channel list",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"List all channels"

@astorije astorije added this to the 2.7.0 milestone Dec 8, 2017
@astorije
Copy link
Member

astorije commented Dec 8, 2017

Adding to v2.7.0 milestone as it's super trivial.

@MaxLeiter
Copy link
Member Author

Should be good to go

Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@xPaw xPaw merged commit de98c2b into thelounge:master Dec 9, 2017
@MaxLeiter MaxLeiter deleted the chanlist branch December 9, 2017 23:09
@astorije astorije changed the title Add 'Channel list' to network context menu Add "Channel list" to network context menu Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants