Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not keep scroll to bottom in inactive channels #1739

Merged
merged 1 commit into from
Nov 26, 2017
Merged

Do not keep scroll to bottom in inactive channels #1739

merged 1 commit into from
Nov 26, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Nov 23, 2017 •
edited
Loading

Should prevent unnecessary and expensive layout/paint triggers.

This needs to keep handleImageInPreview logic, but only call keepToBottom for active channel.

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Nov 23, 2017
@xPaw xPaw added this to the 2.7.0 milestone Nov 23, 2017
@astorije
Copy link
Member

This is supposed to be a no-op for the user, right? Meaning, when testing this, I should not expect any visual change. If so then this acts as expected but I did very little testing, feel free to do more before merging.

@xPaw xPaw merged commit 5ffeb04 into master Nov 26, 2017
@xPaw xPaw deleted the xpaw/inactive-scroll branch November 26, 2017 09:40
@xPaw xPaw mentioned this pull request Nov 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xPaw @astorije