Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup client manager functions #1636

Merged
merged 1 commit into from
Oct 29, 2017
Merged

Cleanup client manager functions #1636

merged 1 commit into from
Oct 29, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Oct 15, 2017

  • Fixes Verify username consistency #1592
  • Checks if a file exists directly instead of reading the whole users folder and checking in the array.
  • Some error handling cleanup

@xPaw xPaw added the Meta: Internal This is an internal codebase change (testing, linting, etc.). label Oct 15, 2017
@xPaw xPaw added this to the 2.6.0 milestone Oct 15, 2017
@xPaw xPaw mentioned this pull request Oct 23, 2017
Merged
@MaxLeiter
Copy link
Member

MaxLeiter commented Oct 23, 2017 •
edited
Loading

👍 works for me

@xPaw xPaw merged commit 81e3e88 into master Oct 29, 2017
@xPaw xPaw deleted the xpaw/cleanup-clientmanager branch October 29, 2017 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
Meta: Internal This is an internal codebase change (testing, linting, etc.).
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xPaw @MaxLeiter @astorije