Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase font size on desktops and mobiles #1553

Merged
merged 1 commit into from
Sep 21, 2017
Merged

Conversation

astorije
Copy link
Member

@astorije astorije commented Sep 21, 2017

Fixes #841.

This increases fonts that use to be monospace before #1540 and ended up being smaller as a side effect.

  • Increase by a little bit on message window (except on message input, unfortunately, but that was adding a scrollbar to the input, then fixing this would misalign borders, etc. not for this PR).
  • Increase a bit more on tablets and phones. The result is really great there, finally not tiny texts anymore, and this + native font stack really makes it look like a native chat app.
  • Remove the font size for extra large screens now that message window size is bigger.

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Sep 21, 2017
@astorije astorije added this to the 2.5.0 milestone Sep 21, 2017
@xPaw
Copy link
Member

xPaw commented Sep 21, 2017

@astorije
Copy link
Member Author

Good catch @xPaw, will remove!

@astorije astorije force-pushed the astorije/bigger-fonts branch from 929812f to 3eaf12c Compare September 21, 2017 07:26
@astorije
Copy link
Member Author

Done!

@fnutt
Copy link
Contributor

fnutt commented Sep 21, 2017

I'm not so sure I fancy larger text on phones. It's already a small screen with not much of the channel showing. Larger text would mean less communication is showing and more scrolling. 👎

@astorije
Copy link
Member Author

You can always decrease the font-size using custom CSS to your liking, but by default right now the font size is waaaay too small, much smaller than any other chat app (or app at all) I've been encountering.

Copy link
Member

@AlMcKinlay AlMcKinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already made my feelings clear about text sizes, so I won't repeat them, but I also won't stand in the way for the exact same reason.

@xPaw xPaw merged commit ede5639 into master Sep 21, 2017
@xPaw xPaw deleted the astorije/bigger-fonts branch September 21, 2017 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small default font size
4 participants