Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL parser incorrectly escapes characters #199

Closed
Jay2k1 opened this issue Mar 16, 2016 · 7 comments
Closed

URL parser incorrectly escapes characters #199

Jay2k1 opened this issue Mar 16, 2016 · 7 comments
Assignees
@maxpoulin64
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Milestone
2.3.0

Comments

@Jay2k1
Copy link
Member

Jay2k1 commented Mar 16, 2016

If a URL followed by a " is posted, the " becomes part of the clickable link which leads to the browser opening a wrong address and the user most likely getting a 404 or worse.
Additionally, a semicolon (;) is being added after the " following the URL.

image
@maxpoulin64 maxpoulin64 added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Mar 19, 2016
@maxpoulin64 maxpoulin64 self-assigned this Mar 19, 2016
@maxpoulin64
Copy link
Member

Yep, one more in the already long list of parser issues.

@xPaw xPaw changed the title Bug in URL parser when URL is followed by " URL parser incorrectly escapes characters Apr 17, 2016
@xPaw xPaw mentioned this issue Apr 17, 2016
Closed
@xPaw
Copy link
Member

xPaw commented Apr 18, 2016

The url parser is generally quite buggy. For example www. gets parsed as a link, despite there not being any domain.

@maxpoulin64 maxpoulin64 mentioned this issue Jul 21, 2016
Closed
@Bonuspunkt Bonuspunkt mentioned this issue Oct 19, 2016
Closed
@AlMcKinlay
Copy link
Member

AlMcKinlay commented Dec 20, 2016 •
edited
Loading

Is there any reason we can't use something like linkifyjs for this? It has to be better than what we are currently using. (It seems to fix a lot of our issues)

@xPaw
Copy link
Member

xPaw commented Dec 20, 2016

@YaManicKill should be fixed in #699 either way.

@astorije
Copy link
Member

Also, bumping URI.js to latest version would fix some of our issues too.

@xPaw xPaw added this to the 2.3.0 milestone Mar 18, 2017
@xPaw xPaw mentioned this issue Mar 18, 2017
Merged
@astorije
Copy link
Member

Hey @Jay2k1, #972 should have fixed that. Mind testing your examples on master?

@Jay2k1
Copy link
Member Author

Jay2k1 commented Apr 22, 2017

Yes, my example now works as you'd expect it to. Thanks!

eliemichel pushed a commit to eliemichel/lounge that referenced this issue Aug 31, 2017
@Bonuspunkt @eliemichel
Add bonuspunkt's parser
b43a85a 
Fixes thelounge#15.
Fixes thelounge#199.
Fixes thelounge#583.
Fixes thelounge#654.
Fixes thelounge#928.
Fixes thelounge#1001.
matburnham pushed a commit to matburnham/lounge that referenced this issue Sep 6, 2017
@Bonuspunkt @xPaw
Add bonuspunkt's parser
77ddf15 
Fixes thelounge#15.
Fixes thelounge#199.
Fixes thelounge#583.
Fixes thelounge#654.
Fixes thelounge#928.
Fixes thelounge#1001.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxpoulin64 maxpoulin64

Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
5 participants
@astorije @xPaw @Jay2k1 @AlMcKinlay @maxpoulin64