Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debian builds #475

Merged
merged 4 commits into from
May 13, 2022
Merged

Fix debian builds #475

merged 4 commits into from
May 13, 2022

Conversation

andyfoston
Copy link
Contributor

@andyfoston andyfoston commented May 12, 2022 •
edited by sync-by-unito bot
Loading

Include missing build dependencies
Ensure setuptools isn't upgraded during pip install step

┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1507
┆priority: Medium

@andyfoston
Fix debian builds
ed262d5 
Include missing build dependencies
Ensure setuptools isn't upgraded
@adejanovski
Copy link
Contributor

Hi @andyfoston, should that PR fix the failing Focal builds?
If so, could you re-enable those in CI so we can see if it works?
The matrix needs to be updated here.

Thanks!

@andyfoston
Copy link
Contributor Author

Hi @andyfoston, should that PR fix the failing Focal builds? If so, could you re-enable those in CI so we can see if it works? The matrix needs to be updated here.

Thanks!

Hi, yeah this does. Sorry, I didn't spot that this had been commented out. I'll enable it

@andyfoston andyfoston mentioned this pull request May 12, 2022
Merged
adejanovski
adejanovski reviewed May 12, 2022
View reviewed changes
.github/workflows/ci.yml
@@ -308,11 +308,10 @@ jobs:
strategy:
matrix:
# Focal builds are broken in CI, we can only build bionic for now
#suite: [focal, bionic]
suite: [bionic]
suite: [focal, bionic]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the publish job for the debian packages, which only happens at release time. We have another job at the top of the workflow that builds the debian packages and tests that they install fine.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, my mistake. I've fixed this now

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.8% 3.8% Duplication

@adejanovski
Copy link
Contributor

It works!!!

Thanks @andyfoston, you're a life savior!! 🙏 🥳

@adejanovski adejanovski merged commit 1eee340 into thelastpickle:master May 13, 2022
@andyfoston andyfoston deleted the fix-debian-builds branch May 13, 2022 08:19
adejanovski pushed a commit that referenced this pull request Jun 23, 2022
@andyfoston @adejanovski
Fix debian Focal builds (#475)
d5aeb94 
Include missing build dependencies
Ensure setuptools isn't upgraded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adejanovski adejanovski adejanovski left review comments

@andyfoston-sky andyfoston-sky andyfoston-sky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyfoston @adejanovski @andyfoston-sky