Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build medusa cli in docker files #460

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Build medusa cli in docker files #460

merged 3 commits into from
Apr 27, 2022

Conversation

Dutchy-
Copy link
Contributor

@Dutchy- Dutchy- commented Mar 31, 2022

This PR adds support for using the medusa cli inside the docker containers.

Before:

$ docker run -it --rm --entrypoint medusa medusa-test
docker: Error response from daemon: OCI runtime create failed: container_linux.go:380: starting container process caused: exec: "medusa": executable file not found in $PATH: unknown.

After:

$ docker run -it --rm --entrypoint medusa medusa-test
Usage: medusa [OPTIONS] COMMAND [ARGS]...

Options:
 ( ... )

┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1374
┆priority: Medium

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Dutchy-
Copy link
Contributor Author

Dutchy- commented Mar 31, 2022

I see 2 failing integration checks but as far as I can tell these are not related to my changes - I don't see anything related to the docker builds in the actions that have been run.

Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @Dutchy- !!

Thanks a lot, I've been wanting this for a while now.

@adejanovski adejanovski merged commit 4c1210d into thelastpickle:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants