Update client to exit with proper code based on errors #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
client.js is not only a Node.js application. This patch is not valid as-is. |
|
This patch is still not valid. The runner topics are for the runner only. |
|
Added in 55d5644 |
jason0x43
pushed a commit
to jason0x43/intern
that referenced
this pull request
Jul 7, 2020
Fixes theintern#7. Closes theintern#11. Closes theintern#14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
clientdoesn't exit with the right code when errors occur in a test likerunnerdoes. This should add the exact same logic toclient.