Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

misc: update images to use builtin and vscode extensions #312

Merged
merged 4 commits into from
Mar 1, 2020

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Feb 21, 2020

What it does

The pull-request updates the following images to include builtin and vscode extensions (the changes are necessary for when the deprecated extensions are removed):

How to test

Verify that CI successfully passes for:

  • swift
  • ruby
  • dart

Review checklist

Reminder for reviewers

Signed-off-by: Vincent Fugnitto [email protected]

Fixes #308

- updates the image to include builtin and external extensions
- adds vscode `dart` support
- adds vscode `flutter` support
- removes deprecated extensions

Signed-off-by: vince-fugnitto <[email protected]>
Fixes #309

- updates the `ruby` images to use vscode extensions.

Signed-off-by: vince-fugnitto <[email protected]>
Fixes #311

- updates the `swift` image to make use of the builtins.

Signed-off-by: vince-fugnitto <[email protected]>
Fixes #315

Updates the remaining images and examples to not
use the deprecated extensions. The `builtins` are added
to these examples for others to reference.

Signed-off-by: Vincent Fugnitto <[email protected]>
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tried, but let's merge it? cc @marcdumais-work

@marcdumais-work marcdumais-work merged commit 206b845 into master Mar 1, 2020
@marcdumais-work marcdumais-work deleted the vf/ext-updates branch March 1, 2020 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.