This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
go: update go images to use vscode extensions #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
force-pushed
the
vf/go-update
branch
from
2a8a580 to
e66aab9
Compare
vince-fugnitto
force-pushed
the
vf/go-update
branch
from
e66aab9 to
df9246a
Compare
- updates the `theia-go:latest` and `theia-go:next` images to use builtin and external extensions. - makes use of the `download:plugins` script to pull plugins from releases. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/go-update
branch
from
df9246a to
3cf7142
Compare
marcdumais-work
approved these changes
Feb 11, 2020
This was referenced Feb 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
theia-go:latestandtheia-go:nextimages to use builtin and external extensions.download-adaptersscript to instead use thedownload:pluginsscript to both pull the builtins and the vscode-golang extensionHow to test
Build and verify the changes for both
theia-go:latestandtheia-go:nextimages(that plugins are downloaded and picked up when started)
Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto [email protected]