Serve from cache when response.code != 200 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll refactor it even more, to serve from cache for other errors as well. |
Example: You have a loadbalancer in between Puppet and Foreman and it'll serve a 503 when the backend(s) (actual Foreman) are down, it wouldn't serve from the cache without this new NodeRetrievalError exception So raising the exception, still logging a useful message but serving from cache makes the most sense here
|
Ok, done. Feel free to review now :) |
idl0r
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a loadbalancer in between Puppet and Foreman for example
and it'll serve a 503 when the backend(s) (actual Foreman) are down, it
wouldn't serve from the cache without catching the
Net::HTTPServiceUnavailable exception
For that to work we had to implement a new Exception,
ForemanUnavailableError, since Net::HTTPServiceUnavailable is not an
actual exception.