Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubygem-facter to 4.5.0 #9726

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Update rubygem-facter to 4.5.0 #9726

merged 1 commit into from
Nov 6, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Aug 27, 2023 •
edited
Loading

No description provided.

@github-actions github-actions bot force-pushed the bump_rpm/rubygem-facter branch from a14c177 to 18ba03f Compare September 3, 2023 04:10
@ekohl
Copy link
Member

ekohl commented Sep 4, 2023 

[2023-09-03T04:16:44.749Z]     package: rubygem-facter-4.4.3-1.el8.noarch from downloaded_rpms
[2023-09-03T04:16:44.749Z]       unresolved deps:
[2023-09-03T04:16:44.749Z]         (rubygem(sys-filesystem) >= 1.3 with rubygem(sys-filesystem) < 2)

@github-actions github-actions bot force-pushed the bump_rpm/rubygem-facter branch 5 times, most recently from 855a471 to 4cd7db9 Compare September 13, 2023 12:16
@github-actions github-actions bot force-pushed the bump_rpm/rubygem-facter branch 2 times, most recently from e63d627 to 93eefbb Compare September 24, 2023 04:10
@github-actions github-actions bot changed the title Update rubygem-facter to 4.4.3 Update rubygem-facter to 4.5.0 Nov 5, 2023
@github-actions github-actions bot force-pushed the bump_rpm/rubygem-facter branch from 93eefbb to 774d634 Compare November 5, 2023 04:10
ekohl
ekohl approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sys-filesystem was moved to a soft dependency in puppetlabs/facter#2604 so we won't get the mounts fact, but for Foreman's use case that's irrelevant. We only use the FQDN and domain:
https://github.com/theforeman/foreman/blob/8dda6a6c4e7a0931e47ec81b4649215073afd43b/config/settings.rb#L23-L27

@ekohl ekohl merged commit d071e35 into rpm/develop Nov 6, 2023
@ekohl ekohl deleted the bump_rpm/rubygem-facter branch November 6, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
RPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekohl @theforeman-bot