-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write better documentation #5
Comments
You rule dude, will be looking into this for my project and helping add PRs whenever bugs are found. |
Hey @royalgiant thank you! Let me know if you need any help with using the gem. I haven't updated it in a while since the Mangadex API doesn't change much, but I'm planning on going back soon to iron out certain things. |
@thedrummeraki do you have any idea how to create a proxy to get the images through? Just learned that unless it's through a proxy, I cannot get the images from my deployed app on Heroku. |
Hey there @royalgiant, I'm also having the same issue on mine :/ (https://dexify.herokuapp.com/mangas/browse). I think using a proxy service works well. I never personally bothered with writing one from scratch (though it would be pretty easy with a lightweight framework like Sinatra or NodeJS runtime). I have a project where I came up with a solution to serve images through a route (on Rails), download the image and serve it. Not performant but a good workaround for that project in particular (see it in action here). It works well here because I'm lazy loading images, but may not work in the case of showing up a bunch of covers |
Dude,
https://youranime.moe/ is so darn cool! You have some awesome side hustles
going on, I'm super impressed! I think your "view more" button is broken
though. Got the usual heroku error. I asked their discord and they said
anything that's not a MD or localhost domain (because their whitelisted)
will get that temp cover to go read at MD. The advice they gave me is to
run a proxy service, which it looks like I'll have to do.
I'll probably be running it on my Node App that I have to connect my Rails
project up to Web3.
Here's some current inspirations I'm looking at:
https://github.com/hoangvu12/requests-proxy
https://github.com/Rob--W/cors-anywhere
https://gist.github.com/jimmywarting/ac1be6ea0297c16c477e17f8fbe51347
Best regards,
Donald Lee
Contact Number: +1 (205)835-3859
Connect with me on Linkedin: https://ca.linkedin.com/in/donaldlee50
Check me out at Github: https://github.com/royalgiant
Learn Personal Finance on my Youtube Channel:
https://youtube.com/coursehackclub
…On Fri, Nov 25, 2022 at 10:25 PM Akinyele Cafe-Febrissy < ***@***.***> wrote:
Hey there @royalgiant <https://github.com/royalgiant>, I'm also having
the same issue on mine :/ (https://dexify.herokuapp.com/mangas/browse). I
think using a proxy service works well. I never personally bothered with
writing one from scratch (though it would be pretty easy with a lightweight
framework like Sinatra or NodeJS runtime).
I have a project where I came up with a solution to serve images through a
route (on Rails), download the image and serve it. Not performant but a
good workaround for that project in particular (see it in action here
<https://dexify.herokuapp.com/mangas/browse>). It works well here because
I'm lazy loading images, but may not work in the case of showing up a bunch
of covers
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGOOOX5OZSSN56LEJLXX3LWKF7IZANCNFSM5ETYPJEA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
All of the documentation will be living here. As of today, it is incomplete.
Below is a list of PRs that are responsible for documenting each aspect of the codebase
Mangadex::Api
Mangadex::Internal
Mangadex::Artist
Mangadex::Auth
Mangadex::Author
Mangadex::Chapter
Mangadex::ContentRating
Mangadex::CoverArt
Mangadex::CustomList
Mangadex::Manga
Mangadex::Relationship
Mangadex::ReportReason
Mangadex::ScanlationGroup
Mangadex::Tag
Mangadex::Upload
Mangadex::User
Mangadex::MangadexObject
Mangadex::Types
Mangadex::Version
The text was updated successfully, but these errors were encountered: