Reduce missed Frequency updates, reduce mutex locks, update docs #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 94.43% 94.42% -0.02%
==========================================
Files 2 2
Lines 521 520 -1
==========================================
- Hits 492 491 -1
Misses 15 15
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
theckman
force-pushed
the
better_frequency_handling
branch
4 times, most recently
from
33d2c23 to
b3f7765
Compare
This change is a small update to help make the spinner a bit more robust. The first increases internal channel buffer size for frequency updates, to hopefully non-blocking write dropping an update. The buffer size increase is arbitrary, and calling .Frequency() in a hot loop could still result in dropped updates. The second is the removal of a mutex lock within the Status() method, and an unnecessary nil check. There is not a need for either of them based on how the *Spinner is constructed. The third is some refinemennt of the documentation both in comments on exported identifiers, and comments within the source code.
theckman
force-pushed
the
better_frequency_handling
branch
from
b3f7765 to
8153131
Compare
|
@codecov can't do math. This build is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a small update to help make the spinner a bit more robust.
The first increases internal channel buffer size for frequency updates, to hopefully
non-blocking write dropping an update. The buffer size increase is arbitrary,
and calling .Frequency() in a hot loop could still result in dropped updates.
The second is the removal of a mutex lock within the Status() method, and an
unnecessary nil check. There is not a need for either of them based on how
the *Spinner is constructed.
The third is some refinemennt of the documentation both in comments on exported
identifiers, and comments within the source code.