Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop Lodash #7

Merged
merged 2 commits into from
Aug 18, 2022
Merged

fix: drop Lodash #7

merged 2 commits into from
Aug 18, 2022

Conversation

ruisaraiva19
Copy link
Collaborator

@ruisaraiva19 ruisaraiva19 commented Aug 17, 2022

This drops Lodash as a dependency.

For now, we ditch the Array config support, and later on, when we migrate the cloneDeep function from Lodash we can support it again. Issue #4 will tackle this task.

The isObject function from Lodash was copy&pasted into the src/index.ts file.

@ruisaraiva19 ruisaraiva19 added the bug Something isn't working label Aug 17, 2022
@ruisaraiva19 ruisaraiva19 requested a review from theblang August 17, 2022 18:15
@ruisaraiva19 ruisaraiva19 changed the title fix: bundle dependencies and drop lodash fix: drop Lodash Aug 18, 2022
Small typo fix for the "cloneDeepDeep"
Copy link
Owner

@theblang theblang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 lodash

@theblang theblang merged commit 3d338a9 into main Aug 18, 2022
@theblang theblang deleted the bundle-dependencies branch August 18, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants