Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

极简首页组件:“默认标签页”始终为“动态”,设置选项无法生效 #3817

Closed
Ethkuil opened this issue Nov 15, 2022 · 8 comments
Labels
bug bug

Comments

@Ethkuil
Copy link
Contributor

Ethkuil commented Nov 15, 2022

对应功能

内部名称:minimalHome,Commit: 3869a14 (为最新正式版)

问题描述

其中一项“默认标签页”选项无法生效,具体表现为:我设置了默认标签页为推荐,但首页还是显示动态,推荐在第二页。

#3331 (comment)

脚本版本

v2.5.1-15-g3869a146c

浏览器版本

Version 107.0.5304.107 (Official Build) (64-bit)

播放器版本

3.22

播放策略

默认

错误信息

无报错信息

附加截图

No response

@Ethkuil
Copy link
Contributor Author

Ethkuil commented Nov 15, 2022

另外吐槽一下不解之处,为何要把 “热门” 与 “个性化推荐” 挤在一个标签页里二选一呢,分别可选不也挺好吗?

@the1812
Copy link
Owner

the1812 commented Nov 15, 2022

不是所有人都喜欢看到个性化推荐

@Ethkuil
Copy link
Contributor Author

Ethkuil commented Nov 15, 2022

我的意思是类似于这样:

动态 <选择是否开启>
热门 <选择是否开启>
个性化推荐 <选择是否开启>

@the1812
Copy link
Owner

the1812 commented Nov 15, 2022

那样又要加两个开关,还要准备全关闭时的空态页,想到这里就懒得加了(

@Ethkuil
Copy link
Contributor Author

Ethkuil commented Nov 15, 2022

这占整个组件的工作量应该近乎可以忽略(

@Ethkuil
Copy link
Contributor Author

Ethkuil commented Nov 15, 2022

我今晚比较有空,如果你不打算马上改这两个地方的话,我可以试试分 2 个 commit 改完发个 PR。

@the1812
Copy link
Owner

the1812 commented Nov 15, 2022

可以的,我这周要修别的 bug

@the1812 the1812 added the bug bug label Nov 18, 2022
the1812 added a commit that referenced this issue Nov 18, 2022
@the1812
Copy link
Owner

the1812 commented Nov 18, 2022

我今晚有空就先修了(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug
Projects
None yet
Development

No branches or pull requests

2 participants