Add Keymaps VIA VRYNBOARD #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
@zlabkeeb any particular reason why the default QMK keymap has more key and layer defines compared to the VIA one in this PR? |
|
Because I followed the keymap recommendations from QMK previously, which I have already PR'd, and everything was fine. Do you have any recommendations for what I should do? |
|
QMK: this PR the keymap merged in QMK and the one in this PR mismatch, that's what I'm referring to. Since they both affect the same fixed layout it makes sense for them to be the same. |
|
Alright, I will match the VIA keymap to be the same as the QMK keymap |
|
@Cipulot |
Cipulot
approved these changes
Oct 8, 2024
|
Super Thanks @Cipulot 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Keymaps VRYNBOARD
QMK Pull Request
qmk/qmk_firmware#23931
Checklist
0xFEED