Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding VIA support for waffling80 #1233

Merged
merged 2 commits into from
Jul 24, 2022
Merged

Adding VIA support for waffling80 #1233

merged 2 commits into from
Jul 24, 2022

Conversation

4pplet
Copy link
Contributor

@4pplet 4pplet commented Apr 13, 2022 •
edited
Loading

Description

Adding VIA support for waffling80, a open sourced multi layout F12/F13 PCB: https://github.com/4pplet/waffling80

QMK Pull Request

qmk/qmk_firmware#16726

Checklist

  • The VIA support for this keyboard is in QMK master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

Thanks! <3

@4pplet
Copy link
Contributor Author

4pplet commented Jul 23, 2022

@yiancar could you also have a look at this? I'm not sure why the deploy-preview fails for the updated json

Thanks! <3

@yiancar
Copy link
Collaborator

yiancar commented Jul 24, 2022

Dont worry, that check its now superseded.

Enjoy!

@yiancar yiancar merged commit 5ba49e9 into the-via:master Jul 24, 2022
@4pplet 4pplet deleted the add_waffling80 branch July 30, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4pplet @yiancar