Add template for the translation #2380
Conversation
✅ Deploy Preview for the-turing-way ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
BatoolMM
added
the
book-dash-may22
Co-authored-by: Alejandro © <[email protected]>
Co-authored-by: Alejandro © <[email protected]>
Co-authored-by: Alejandro © <[email protected]>
Co-authored-by: Alejandro © <[email protected]>
Co-authored-by: Alejandro © <[email protected]>
malvikasharan
dismissed
acocac’s stale review
Not dismissing - but unblocking it merge. Thank you Alejandro and Batool for this wonderful addition.
|
@all-contributors please add @BatoolMM for maintenance and doc |
|
I've put up a pull request to add @BatoolMM! 🎉 |
|
@all-contributors please add @acocac for maintenance and doc |
|
I've put up a pull request to add @acocac! 🎉 |
There was a problem hiding this comment.
Hi @BatoolMM,
Apologies for the delay. I left some comments when your PR was first opened but forgot to click "Submit Review" so all my comments didn't show!
Only realized it today when I was wondering why there was no response. >.<
Best Regards,
Tim
| - [ ] *Target langauge is .* | ||
| - [ ] *I wish to be manager in Crowdin to entries for this language.* | ||
| - [ ] *I will only proofread translation for this language.* | ||
|
|
There was a problem hiding this comment.
would an additional checkbox for "Do you have local translation to be uploaded to the Translation Memory?" or something along those lines be helpful?
Maybe it could also be its own standalone question - then with different languages or files as checkboxes?
| - [ ] *I will only proofread translation for this language.* | ||
|
|
||
|
|
||
| ### What is the sections/chapter you want to translate? |
There was a problem hiding this comment.
"sections/chapter" -> "sections/chapters"
There was a problem hiding this comment.
Hi @BatoolMM,
Apologies for the delay. I left some comments when your PR was first opened but forgot to click "Submit Review" so all my comments didn't show!
Only realized it today when I was wondering why there was no response. >.<
Don't worry at all, thank you so much, Timothy for taking the time to review it. Your input added a great value to the template and the translation. Let me know if I missed any of the changes you requested.
Thank you again!
| --> | ||
| ### Summary | ||
|
|
||
| <!-- Please provide a detailed description of the language that you want to translate to and the chapters that you would like to translate. |
There was a problem hiding this comment.
"language" -> "language/languages"?
|
|
||
| *Lorem ipsum dolor sit amet, consectetur adipiscing.* | ||
|
|
||
| ### What is the target language? |
There was a problem hiding this comment.
"target language" -> "target language/languages"?
| <!-- Is your langauge added to Crowdin or you need to be added? | ||
| We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> | ||
|
|
||
| - [ ] *Target language is .* |
There was a problem hiding this comment.
"Target langauge is ." -> "Target language/languages is/are"? - just a thought
|
|
||
| ### What is the target language? | ||
|
|
||
| <!-- Is your langauge added to Crowdin or you need to be added? |
There was a problem hiding this comment.
minor typo. "langauge" -> "language"
|
Thank you all. This looks good to me. Please do merge this when ready. |
Summary
This is a template for the translation made in Crowdin, related to #2365. It's based largely on the already existed templates with minor changes.
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?
Acknowledging contributors