Add containsSupergraphSpec #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kamilkisiela
pushed a commit
that referenced
this pull request
Feb 22, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @theguild/[email protected] ### Patch Changes - [#46](#46) [`cfa9950`](cfa9950) Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - Add `requiresScopes__Scope` and `policy__Policy` to `transformSupergraphToPublicSchema` - [#44](#44) [`de983b0`](de983b0) Thanks [@kamilkisiela](https://github.com/kamilkisiela)! - Add containsSupergraphSpec to detect if Supergraph related scalars, enums or directives are used Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is meant to quickly check if
transformSupergraphToPublicSchemais needed.Obviously, in most cases when
transformSupergraphToPublicSchemais used, a provided schema contains Supergraph spec (join__Graph etc).Why do I create it then?
We have a special case in GraphQL Hive where we persist the output of
transformSupergraphToPublicSchema, but when Apollo Federation adds something new, we might want to run this method again to remove new pieces.Performance
I used a Supergraph SDL with ~20k LOC and create three copies.
First copy used
field(whatever: join__Graph)as an argument somewhere in the middle.Second copy had
scalar join__DirectiveArguments, also in the middle of the file.Third copy had
directive @join__directivedefinition (yeah yeah, in the middle).I wrote three versions of
containsSupergraphSpecto make sure it has minimal performance footprint.sdl.includes("[name") or sdl.includes(" name")I ran it 1000 times and I got (average):