fix(project): fix lots of things

the-bugging · Aug 11, 2020 · 76aabd6 · 76aabd6
1 parent 3b17844
commit 76aabd6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 20 deletions.
diff --git a/src/index.tsx b/src/index.tsx
@@ -35,7 +35,7 @@ export function useHotjar(): TUseHotjar {
   const identityHotjar = React.useCallback(
     (userId: string, userInfo: string, shouldLog = true): boolean => {
       try {
-        const hotjarIdentityScript = `var userId="${userId}" || null;window.hj("identify",userId,{${userInfo}}});`;
+        const hotjarIdentityScript = `var userId="${userId}" || null;window.hj("identify",userId,${userInfo});`;
         const isIdentified = appendHeadScript({
           scriptText: hotjarIdentityScript,
           scriptId: 'identity-script',

diff --git a/src/useAppendHeadScript.ts b/src/useAppendHeadScript.ts
@@ -10,26 +10,26 @@ type TUseAppendHeadScript = {
 };
 
 export function useAppendHeadScript(): TUseAppendHeadScript {
-  const appendHeadScript = ({
-    scriptText,
-    scriptId,
-  }: TAppendHeadScript): boolean => {
-    try {
-      const existentScript = document.getElementById(
-        scriptId
-      ) as HTMLScriptElement;
-      const script = existentScript || document.createElement('script');
-      script.id = scriptId;
-      script.innerText = scriptText;
-      script.crossOrigin = 'anonymous';
+  const appendHeadScript = React.useCallback(
+    ({ scriptText, scriptId }: TAppendHeadScript): boolean => {
+      try {
+        const existentScript = document.getElementById(
+          scriptId
+        ) as HTMLScriptElement;
+        const script = existentScript || document.createElement('script');
+        script.id = scriptId;
+        script.innerText = scriptText;
+        script.crossOrigin = 'anonymous';
 
-      document.head.appendChild(script);
+        document.head.appendChild(script);
 
-      return true;
-    } catch (error) {
-      return error;
-    }
-  };
+        return true;
+      } catch {
+        return false;
+      }
+    },
+    []
+  );
 
-  return React.useMemo(() => ({ appendHeadScript }), []);
+  return React.useMemo(() => ({ appendHeadScript }), [appendHeadScript]);
 }