Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source code and documentation links on RubyGems.org #71

Merged
merged 1 commit into from
May 12, 2019

Conversation

janko
Copy link
Contributor

@janko janko commented May 9, 2019

This should add a "Source Code" link on RubyGems.org, which I was missing when looking into Kiba.

While here, I also changed the "Documentation" link to point to the wiki, as I thought it's more useful than the default rubydoc.info link.

I also wanted to add a GitHub corner link to the Kiba website (as it doesn't seem to have a GitHub link atm), but I couldn't find the source code.

@thbar
Copy link
Owner

thbar commented May 9, 2019

Thanks for the PR, much appreciated! I'll review that soon.

About the corner link - I'm in the process of redesigning the site, I will check if I can put it or not.

Thanks!

@thbar thbar self-requested a review May 12, 2019 21:45
@thbar
Copy link
Owner

thbar commented May 12, 2019

Note to self: the reference is available here https://guides.rubygems.org/specification-reference/.

Many thanks @janko - merging, and I will verify the behaviour with the v2.5 (soon out) release!

@thbar thbar merged commit 1e9b4d2 into thbar:master May 12, 2019
@thbar
Copy link
Owner

thbar commented May 29, 2019

Kiba v2.5.0 is out, and the links you provided work perfectly on rubygems.org. Thank you @janko!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants