Rama/ibc #107
Merged
Rama/ibc #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramacarlucho
requested review from
fedekunze,
jolube and
khoslaventures
as code owners
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 74.47% 74.27% -0.21%
==========================================
Files 22 23 +1
Lines 1610 1648 +38
==========================================
+ Hits 1199 1224 +25
- Misses 354 365 +11
- Partials 57 59 +2
|
fedekunze
reviewed
Nov 23, 2021
go.mod
Outdated
| @@ -5,6 +5,7 @@ go 1.17 | |||
| require ( | |||
| contrib.go.opencensus.io/exporter/prometheus v0.4.0 | |||
| github.com/cosmos/cosmos-sdk v0.44.3 | |||
| github.com/cosmos/ibc-go v1.2.3 | |||
There was a problem hiding this comment.
we can remove this since we are using v2
| @@ -69,6 +70,10 @@ func (rtbp *RegisterCoinProposal) ValidateBasic() error { | |||
| return err | |||
| } | |||
|
|
|||
| if err := ibctransfertypes.ValidateIBCDenom(rtbp.Metadata.Base); err != nil { | |||
There was a problem hiding this comment.
nice, we should also check that the metadata has the correct format
There was a problem hiding this comment.
following up on this, we should check that the format for IBC vouchers is the same as the one you wrote on the tests
fedekunze
reviewed
Nov 23, 2021
fedekunze
reviewed
Nov 23, 2021
go.sum
Outdated
Comment on lines
238
to
239
| github.com/cosmos/ibc-go v1.2.3 h1:+Xdhshvls9c6NQNAj7jz5YUtpqCd7AwadEImpaeVReo= | ||
| github.com/cosmos/ibc-go v1.2.3/go.mod h1:TNJMo+fPU4GmpAGxqedjuA1l6izRLGPvuIRLpWAbXuE= |
| @@ -69,6 +70,10 @@ func (rtbp *RegisterCoinProposal) ValidateBasic() error { | |||
| return err | |||
| } | |||
|
|
|||
| if err := ibctransfertypes.ValidateIBCDenom(rtbp.Metadata.Base); err != nil { | |||
There was a problem hiding this comment.
following up on this, we should check that the format for IBC vouchers is the same as the one you wrote on the tests
fedekunze
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
Add validate ibc-denom to support ibc
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)