Skip to content

Commit

Permalink
linter and changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
ramacarlucho committed Nov 23, 2021
1 parent bfe6d3b commit fa8db24
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

## Improvements

* (intrarelayer) [\#107](https://github.com/tharsis/evmos/pull/107) Add IBC validation
* (cmd) [\#105](https://github.com/tharsis/evmos/pull/105) Improve testnet command to include JSON-RPC client.

## Bug Fixes
Expand Down
1 change: 0 additions & 1 deletion x/intrarelayer/keeper/proposals.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ func (k Keeper) verifyMetadata(ctx sdk.Context, coinMetadata banktypes.Metadata)

// DeployERC20Contract creates and deploys an ERC20 contract on the EVM with the intrarelayer module account as owner
func (k Keeper) DeployERC20Contract(ctx sdk.Context, coinMetadata banktypes.Metadata) (common.Address, error) {

ctorArgs, err := contracts.ERC20BurnableAndMintableContract.ABI.Pack("", coinMetadata.Name, coinMetadata.Symbol)
if err != nil {
return common.Address{}, sdkerrors.Wrapf(err, "coin metadata is invalid %s", coinMetadata.Name)
Expand Down
2 changes: 1 addition & 1 deletion x/intrarelayer/types/proposal.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func validateIBC(metadata banktypes.Metadata) error {
}

if len(denomSplit) != 2 || denomSplit[0] != ibctransfertypes.DenomPrefix {
//NOTE: should be unaccessible (covered on ValidateIBCDenom)
// NOTE: should be unaccessible (covered on ValidateIBCDenom)
return fmt.Errorf("invalid metadata. %s denomination should be prefixed with the format 'ibc/", metadata.Base)
}

Expand Down

0 comments on commit fa8db24

Please sign in to comment.