query : add missing xincrease/xrate aggregation #8120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: miinsun <[email protected]>
|
I'm really honored to be making my first open-source PR!!! But I can't seem to merge it. @yeya24 Can you help me with that? |
MichaHoffmann
approved these changes
Feb 25, 2025
E2E test was flaky; ill rerun |
GregSharpe1
added a commit
to GregSharpe1/thanos
that referenced
this pull request
Feb 26, 2025
…/thanos into doc/vertical-compaction-flag * 'doc/vertical-compaction-flag' of github.com:GregSharpe1/thanos: Infer max query downsample resolution from promql query (thanos-io#7012) query : add missing xincrease/xrate aggregation (thanos-io#8120) build(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp (thanos-io#8067) [issue-8106] fix tenant hashring glob with multiple match patterns (thanos-io#8107) Query: dynamic endpointgroups are allowed (thanos-io#8113) Remove quote from replica label. (thanos-io#8075) *: bump Go to 1.24 (thanos-io#8105) build(deps): bump github.com/tjhop/slog-gokit from 0.1.2 to 0.1.3 (thanos-io#8109) Update prometheus verison to v3.1.0 (thanos-io#8090) store: lock around iterating over s.blocks (thanos-io#8088) Fix deadlock in metadata fetcher (thanos-io#8092) fix: add POST into allowed CORS methods header (thanos-io#8091) Add a func to convert go-kit log to slog (thanos-io#7969) Extend posting-group-max-key-series-ratio for add all posting group (thanos-io#8083) skip match label values for certain matchers (thanos-io#8084)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
see #8111
The
aggrsFromFuncfunction was missing the COUNTER aggregation forxincreaseandxrate. I added these functions to the conditional check to ensure proper aggregation.Verification