Set index cache ttl based on block meta #8089
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Set-index-cache-ttl-based-on-block-meta
branch
from
7811a90 to
d57f685
Compare
yeya24
reviewed
Feb 5, 2025
| // CacheTTL returns cache TTL based on the block meta. A Short TTL is useful for | ||
| // temporary blocks that will be compacted soon and a long TTL for large blocks | ||
| // that won't be compacted. | ||
| func CacheTTL(meta *metadata.Meta) time.Duration { |
There was a problem hiding this comment.
For my usecase, I would like to take cache item type into consideration. I want to cache expanded postings with a larger TTL and postings for smaller TTL. Do we have a good way to make this customizable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes TTL to the index cache to set cache TTL differently based on block metadata. We can use a short TTL for temporary blocks that will be compacted soon and a long TTL for large blocks that won't be compacted.
Changes
Expose TTL for store functions of the index cache to set cache TTL differently based on block metadata.
Verification