pkg/cacheutil: Async op fix #8044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2025 16:25
The existing implementation sometimes drops existing operations that are still on the queue when .stop() is called. If multiple communications in a select statement can proceed, one is chosen pseudo-randomly: https://go.dev/ref/spec#Select_statements This means that sometimes a processor worker will process a remaining operation, and sometimes it won't. Signed-off-by: Daniel Sabsay <[email protected]>
Signed-off-by: Daniel Sabsay <[email protected]>
|
For context, the result of this bug is flaky tests: cortexproject/cortex#6480 |
2 tasks
GiedriusS
previously approved these changes
Jan 7, 2025
GiedriusS
reviewed
Jan 7, 2025
| @@ -0,0 +1,33 @@ | |||
| package cacheutil | |||
There was a problem hiding this comment.
You are missing a header here, please add it.
added 2 commits
January 8, 2025 10:23
Signed-off-by: Daniel Sabsay <[email protected]>
|
@GiedriusS I think this is ready now. Please take a look when you have a chance. |
GiedriusS
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes the test in #8043. That separate PR was only to show that the test fails in CI.
The existing implementation sometimes drops existing operations that are
still on the queue when .stop() is called.
If multiple communications in a select statement can proceed, one is
chosen pseudo-randomly: https://go.dev/ref/spec#Select_statements
This means that sometimes a processor worker will process a remaining
operation, and sometimes it won't.
Verification
I ran the test multiple times locally, switching between the old implementation of
asyncQueueProcessLoop()and this new one.Additionally, #8043 shows that the new test fails in CI with the old implementation.