Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): fix GOMEMLIMIT pull request reference #7250

Merged

Conversation

roth-wine
Copy link
Contributor

  • Change is not relevant to the end user.

Changes

  • The pull request reference for the introduction of GOMEMLIMIT is incorrect.

Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@fpetkovski fpetkovski enabled auto-merge April 2, 2024 06:18
@fpetkovski
Copy link
Contributor

We just need to to sign the DCO. You can it with

git commit --amend --no-edit --signoff
git push -f

auto-merge was automatically disabled April 2, 2024 06:19

Head branch was pushed to by a user without write access

@roth-wine roth-wine force-pushed the pr-fix-changelog-gomemlimit-reference branch 2 times, most recently from 3566848 to b064c1f Compare April 2, 2024 06:48
@roth-wine roth-wine force-pushed the pr-fix-changelog-gomemlimit-reference branch from b064c1f to 8cdece5 Compare April 2, 2024 06:49
@roth-wine
Copy link
Contributor Author

The DCO should now be correct

@fpetkovski fpetkovski enabled auto-merge April 2, 2024 07:11
@fpetkovski fpetkovski merged commit c7b1cc9 into thanos-io:main Apr 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants