-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade Prometheus dependency version to v2.30.0 #4669
Conversation
Signed-off-by: Ben Ye <[email protected]>
Seems like the CI failure is related to your changes. Could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the test fail is legit, seems like it's coming from this change in Prometheus prometheus/prometheus#9301
Signed-off-by: Ben Ye <[email protected]>
Thanks. But why prometheus/prometheus#9301 is related to the symbols offset change? IIUC 9301 is about TSDB head which is only related to memory? |
I think we are using some of the code that has been touched in that PR in the utility to create blocks (seems like it's within leveled compactor). The specific cause seems to be this change. |
Is it ready to go? @GiedriusS @matej-g |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side ready to go 🚀
* upgrade Prometheus dependency version to v2.30.0 Signed-off-by: Ben Ye <[email protected]> * fix unit test Signed-off-by: Ben Ye <[email protected]>
* upgrade Prometheus dependency version to v2.30.0 Signed-off-by: Ben Ye <[email protected]> * fix unit test Signed-off-by: Ben Ye <[email protected]> # Conflicts: # go.mod # go.sum
* Sidecar: Fix process external label on promethues v2.28+ use units.Bytes config type (#4657) * Sidecar: Fix process external label when promethues v2.28+ use units.Bytes config type (#4656) Signed-off-by: hanjm <[email protected]> * E2E: Upgrade prometheus image version Signed-off-by: hanjm <[email protected]> * upgrade Prometheus dependency version to v2.30.0 (#4669) * upgrade Prometheus dependency version to v2.30.0 Signed-off-by: Ben Ye <[email protected]> * fix unit test Signed-off-by: Ben Ye <[email protected]> # Conflicts: # go.mod # go.sum * Query: Fix (*exemplarsStream).receive/(*metricMetadataStream).receive/(*targetsStreamStream).receive infinite loop when target response Unimplemented error (#4676) (#4681) Signed-off-by: hanjm <[email protected]> * Cut 0.23.0-rc.1 Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Jimmiehan <[email protected]> Co-authored-by: Ben Ye <[email protected]>
* Cut release 0.23.0-rc.0 (#4625) Signed-off-by: Bartlomiej Plotka <[email protected]> * Updated version. Signed-off-by: Bartlomiej Plotka <[email protected]> * Cut 0.23.0-rc.1 and cherry picked 3 critical commits from main. (#4684) * Sidecar: Fix process external label on promethues v2.28+ use units.Bytes config type (#4657) * Sidecar: Fix process external label when promethues v2.28+ use units.Bytes config type (#4656) Signed-off-by: hanjm <[email protected]> * E2E: Upgrade prometheus image version Signed-off-by: hanjm <[email protected]> * upgrade Prometheus dependency version to v2.30.0 (#4669) * upgrade Prometheus dependency version to v2.30.0 Signed-off-by: Ben Ye <[email protected]> * fix unit test Signed-off-by: Ben Ye <[email protected]> # Conflicts: # go.mod # go.sum * Query: Fix (*exemplarsStream).receive/(*metricMetadataStream).receive/(*targetsStreamStream).receive infinite loop when target response Unimplemented error (#4676) (#4681) Signed-off-by: hanjm <[email protected]> * Cut 0.23.0-rc.1 Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Jimmiehan <[email protected]> Co-authored-by: Ben Ye <[email protected]> * Cut 0.23.0 release. (#4697) * Endpointset: Do not use info client to obtain metadata (for now) (#4714) * Do not use info client to obtain metadata Signed-off-by: Matej Gera <[email protected]> * Update CHANGELOG. Signed-off-by: Matej Gera <[email protected]> * Comment out client.info usage Signed-off-by: Matej Gera <[email protected]> * Fix lint error Signed-off-by: Matej Gera <[email protected]> * Cutting 0.23.1 (#4718) Signed-off-by: Bartlomiej Plotka <[email protected]> * Moved tutorials Thanos versions to 0.23.1 Signed-off-by: Bartlomiej Plotka <[email protected]> * Added volounteer for shepharding, fixed VERSION. Signed-off-by: Bartlomiej Plotka <[email protected]> Co-authored-by: Jimmiehan <[email protected]> Co-authored-by: Ben Ye <[email protected]> Co-authored-by: Matej Gera <[email protected]>
* upgrade Prometheus dependency version to v2.30.0 Signed-off-by: Ben Ye <[email protected]> * fix unit test Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye [email protected]
Fixes #4665
Changes
Upgrade Prometheus version to the latest v2.30.0.
This brings in prometheus/prometheus#9097 and some improvements on TSDB as well.
Verification