pkg/receive: avoid false positive conflict err #1616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that the `replicate` func does not falsely identify a replication error as a conflict. If the number of conflict errors during replication is less than the minimum replication threshold, then replication cannot be said to have failed due to a conflict and the request should be retried. Fixes: thanos-io#1615 xref: thanos-io#1563 Signed-off-by: Lucas Servén Marín <[email protected]>
squat
force-pushed
the
avoidfalsepositive
branch
from
b0fc0b3 to
e493646
Compare
brancz
approved these changes
Oct 9, 2019
GiedriusS
pushed a commit
that referenced
this pull request
Oct 28, 2019
This commit ensures that the `replicate` func does not falsely identify a replication error as a conflict. If the number of conflict errors during replication is less than the minimum replication threshold, then replication cannot be said to have failed due to a conflict and the request should be retried. Fixes: #1615 xref: #1563 Signed-off-by: Lucas Servén Marín <[email protected]> Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the
replicatefunc does not falsely identifya replication error as a conflict. If the number of conflict errors
during replication is less than the minimum replication threshold, then
replication cannot be said to have failed due to a conflict and the
request should be retried.
Fixes: #1615
xref: #1563
Signed-off-by: Lucas Servén Marín [email protected]
cc @brancz @dtrejod