Skip to content

Commit

Permalink
treewide: fix typo of gRPC (#5656)
Browse files Browse the repository at this point in the history
Signed-off-by: xdavidwu <[email protected]>

Signed-off-by: xdavidwu <[email protected]>
Co-authored-by: Kemal Akkoyun <[email protected]>
  • Loading branch information
xdavidwu and kakkoyun authored Sep 9, 2022
1 parent 60cddce commit eb9810f
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion docs/proposals-accepted/202107-protobuf-openapi-httpapi.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Similarly, we want to reuse this work in Prometheus.
2. We have gRPC APIs like rules API.
2. Cons:
1. There are might be some complexity, edge cases and extra tooling to make the process (define gRPC API and get RESTful APIs with grpc-gateway) work.
2. We need to redefine our API service in gPRC since most of Thanos APIs and Prometheus APIs are RESTful APIs.
2. We need to redefine our API service in gRPC since most of Thanos APIs and Prometheus APIs are RESTful APIs.
3. We need to run another sidecar (complexity of running the system).
4. Semantics of gRPC and HTTP might be different and surprising for end user.
5. We want to reuse in Prometheus and Prometheus does not support gRPC (gRPC dependency was removed from codebase).
Expand Down
10 changes: 5 additions & 5 deletions examples/dashboards/overview.json
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,7 @@
"thresholds": [ ],
"timeFrom": null,
"timeShift": null,
"title": "gPRC (Unary) Rate",
"title": "gRPC (Unary) Rate",
"tooltip": {
"shared": false,
"sort": 0,
Expand Down Expand Up @@ -833,7 +833,7 @@
"thresholds": [ ],
"timeFrom": null,
"timeShift": null,
"title": "gPRC (Unary) Errors",
"title": "gRPC (Unary) Errors",
"tooltip": {
"shared": false,
"sort": 0,
Expand Down Expand Up @@ -1104,7 +1104,7 @@
"thresholds": [ ],
"timeFrom": null,
"timeShift": null,
"title": "gPRC (Unary) Rate",
"title": "gRPC (Unary) Rate",
"tooltip": {
"shared": false,
"sort": 0,
Expand Down Expand Up @@ -1190,7 +1190,7 @@
"thresholds": [ ],
"timeFrom": null,
"timeShift": null,
"title": "gPRC (Unary) Errors",
"title": "gRPC (Unary) Errors",
"tooltip": {
"shared": false,
"sort": 0,
Expand Down Expand Up @@ -1292,7 +1292,7 @@
],
"timeFrom": null,
"timeShift": null,
"title": "gPRC (Unary) Latency 99th Percentile",
"title": "gRPC (Unary) Latency 99th Percentile",
"tooltip": {
"shared": false,
"sort": 0,
Expand Down
6 changes: 3 additions & 3 deletions mixin/dashboards/sidecar.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -93,18 +93,18 @@ local utils = import '../lib/utils.libsonnet';
__overviewRows__+:: if thanos.sidecar == null then [] else [
g.row('Sidecar')
.addPanel(
g.panel('gPRC (Unary) Rate', 'Shows rate of handled Unary gRPC requests from queriers.') +
g.panel('gRPC (Unary) Rate', 'Shows rate of handled Unary gRPC requests from queriers.') +
g.grpcRequestsPanel('grpc_server_handled_total', utils.joinLabels([thanos.dashboard.overview.selector, 'grpc_type="unary"']), thanos.dashboard.overview.dimensions) +
g.addDashboardLink(thanos.sidecar.title)
)
.addPanel(
g.panel('gPRC (Unary) Errors', 'Shows ratio of errors compared to the total number of handled requests from queriers.') +
g.panel('gRPC (Unary) Errors', 'Shows ratio of errors compared to the total number of handled requests from queriers.') +
g.grpcErrorsPanel('grpc_server_handled_total', utils.joinLabels([thanos.dashboard.overview.selector, 'grpc_type="unary"']), thanos.dashboard.overview.dimensions) +
g.addDashboardLink(thanos.sidecar.title)
)
.addPanel(
g.sloLatency(
'gPRC (Unary) Latency 99th Percentile',
'gRPC (Unary) Latency 99th Percentile',
'Shows how long has it taken to handle requests from queriers, in quantiles.',
'grpc_server_handling_seconds_bucket{%s}' % utils.joinLabels([thanos.dashboard.overview.selector, 'grpc_type="unary"']),
thanos.dashboard.overview.dimensions,
Expand Down
4 changes: 2 additions & 2 deletions mixin/dashboards/store.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -228,12 +228,12 @@ local utils = import '../lib/utils.libsonnet';
__overviewRows__+:: if thanos.store == null then [] else [
g.row('Store')
.addPanel(
g.panel('gPRC (Unary) Rate', 'Shows rate of handled Unary gRPC requests from queriers.') +
g.panel('gRPC (Unary) Rate', 'Shows rate of handled Unary gRPC requests from queriers.') +
g.grpcRequestsPanel('grpc_server_handled_total', utils.joinLabels([thanos.dashboard.overview.selector, 'grpc_type="unary"']), thanos.dashboard.overview.dimensions) +
g.addDashboardLink(thanos.store.title)
)
.addPanel(
g.panel('gPRC (Unary) Errors', 'Shows ratio of errors compared to the total number of handled requests from queriers.') +
g.panel('gRPC (Unary) Errors', 'Shows ratio of errors compared to the total number of handled requests from queriers.') +
g.grpcErrorsPanel('grpc_server_handled_total', utils.joinLabels([thanos.dashboard.overview.selector, 'grpc_type="unary"']), thanos.dashboard.overview.dimensions) +
g.addDashboardLink(thanos.store.title)
)
Expand Down

0 comments on commit eb9810f

Please sign in to comment.