Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: Add HTTP_Config #99

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Swift: Add HTTP_Config #99

merged 1 commit into from
Feb 12, 2024

Conversation

btaani
Copy link
Contributor

@btaani btaani commented Feb 6, 2024

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Adding HTTP Config to swift, similar to other providers, in order to support hedging & TLS
cc @JoaoBraveCoding

Verification

@btaani btaani marked this pull request as ready for review February 7, 2024 13:57
@JoaoBraveCoding
Copy link
Collaborator

@btaani it seems you did not sign your commits, that's why the DCO tool is complaining

@JoaoBraveCoding
Copy link
Collaborator

For maintainers: @btaani PR is contextualized as part of the effort we are doing to try and move Loki objstore clients to use thanos.io/objstore

Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM! This follows #86 I think!

@saswatamcode saswatamcode merged commit a8d75c5 into thanos-io:main Feb 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants