Allow timingReadCloser to be seeker #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cortex uses objstore to update blocks to s3. Cortex had added a retry functionality using seeker objects.
https://github.com/cortexproject/cortex/blob/master/pkg/storage/bucket/s3/bucket_client.go#L176-L191
It checks if an object is seeker and if so it allow it to retry.
It also wrap the bucket store with metrics
https://github.com/cortexproject/cortex/blob/master/pkg/storage/bucket/client.go#L145
With the new timing metrics, ojbstore now override the object and thus change it to always be io.ReadCloser which is what the implementation requires, but it does not allow cortex to retry request anymore.
The change allow it to continue using a seeker object if the original object was seekable.
Verification
Added unit tests to verify the functionality still works.