Add new metric to count total number of fetched bytes from bucket #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @thib-ack 🙇 , I think this change makes sense. Would you mind signing the commits so that we can ensure all the PR checks are green? |
|
I have signed the commits 🖋️ |
Signed-off-by: Thibaut Ackermann <[email protected]>
Signed-off-by: Thibaut Ackermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We are using a cloud provider which bills us on the outgoing trafic, so it is useful for me to know how many bytes are downloaded from the bucket.
I thought maybe others can have the same needs.
Of course if you think that could be useful but want a different implementation, let me know.
Verification
updated
TestDownloadUploadDirConcurrencytest inobjstore_test.gobut I can add more tests if you want.Thanks,